Port lint attributes to attribute parser by Bryntet · Pull Request #152369 · rust-lang/rust

Bryntet · 2026-02-09T01:32:19Z

View all comments

Tracking issue: #131229

Ports #[allow], #[deny], #[expect], #[forbid], and #[warn] to being parsed attrs

I tried my best to make this PR as small as possible, it was difficult. I hope it isn't too difficult to review

r? @JonathanBrouwer
r? @jdonszelmann

rustbot · 2026-02-22T18:57:56Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-02-22T19:22:58Z

@bors try @rust-timer queue

Port lint attributes to attribute parser

compiler/rustc_passes/src/check_attr.rs

rustbot · 2026-03-04T11:35:38Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Bryntet · 2026-03-04T11:36:33Z

@bors try

Port lint attributes to attribute parser

JonathanBrouwer · 2026-03-04T11:39:15Z

@rust-timer queue

Bryntet · 2026-03-04T11:49:10Z

commit 20f3e33 fixes issue #132218

blyxyas · 2026-03-04T13:07:37Z

That sounds like a great idea, but let's do that in a separate PR after this one merged, this one is already big enough :P

Could I take care of that whenever this PR's merged?

rust-bors · 2026-03-04T13:48:32Z

☀️ Try build successful (CI)
Build commit: ac4191a (ac4191a5f4b62a9b6a5b873cb6061893651a855a, parent: d933cf483edf1605142ac6899ff32536c0ad8b22)

JonathanBrouwer · 2026-03-04T13:52:38Z

That sounds like a great idea, but let's do that in a separate PR after this one merged, this one is already big enough :P

Could I take care of that whenever this PR's merged?

Sure, no guarantees of when that is tho :P

Bryntet · 2026-03-04T14:03:57Z

@bors try

Port lint attributes to attribute parser

rust-timer · 2026-03-04T14:28:10Z

Finished benchmarking commit (ac4191a): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.2%, 0.6%]	5
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.1%]	32
Improvements ✅ (secondary)	-0.3%	[-0.7%, -0.0%]	57
All ❌✅ (primary)	-0.3%	[-0.5%, -0.1%]	32

Max RSS (memory usage)

Results (primary 1.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.7%, 2.2%]	4
Regressions ❌ (secondary)	4.3%	[0.8%, 9.0%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.8%	[-4.9%, -4.7%]	2
All ❌✅ (primary)	1.1%	[0.7%, 2.2%]	4

Cycles

Results (primary 3.2%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[1.5%, 4.2%]	6
Regressions ❌ (secondary)	4.0%	[2.3%, 6.3%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-16.4%	[-16.4%, -16.4%]	1
All ❌✅ (primary)	3.2%	[1.5%, 4.2%]	6

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	23
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	57
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	23

Bootstrap: 481.183s -> 479.856s (-0.28%)
Artifact size: 394.90 MiB -> 395.15 MiB (0.06%)

rust-log-analyzer · 2026-03-04T14:41:33Z

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260123.484
Commit: 6bd6555ca37d84114959e1c76d2c01448ff61c5d
Build Date: 2026-01-23T19:41:17Z
Worker ID: {f26a62dd-2965-4b4d-a597-7f282f44addc}
Azure Region: southcentralus
##[endgroup]
##[group]VM Image
- OS: Linux (arm64)
- Source: Partner
- Name: Ubuntu 24.04 by Arm Limited
---
/dev/sda15       98M  6.4M   92M   7% /boot/efi
tmpfs           1.6G   16K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (120307276KB >= 52428800KB). Skipping cleanup.
##[group]Run echo "[CI_PR_NUMBER=$num]"
echo "[CI_PR_NUMBER=$num]"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
set -ex

# Run a subset of tests. Used to run tests in parallel in multiple jobs.

# When this job partition is run as part of PR CI, skip tidy to allow revealing more failures. The
# dedicated `tidy` job failing won't block other PR CI jobs from completing, and so tidy failures
# shouldn't inhibit revealing other failures in PR CI jobs.
if [ "$PR_CI_JOB" == "1" ]; then
  echo "PR_CI_JOB set; skipping tidy"
  SKIP_TIDY="--skip tidy"
fi

../x.py --stage 2 test \
  ${SKIP_TIDY:+$SKIP_TIDY} \
  --skip compiler \
  --skip src
#!/bin/bash

set -ex

# Run a subset of tests. Used to run tests in parallel in multiple jobs.

# When this job partition is run as part of PR CI, skip tidy to allow revealing more failures. The
# dedicated `tidy` job failing won't block other PR CI jobs from completing, and so tidy failures
# shouldn't inhibit revealing other failures in PR CI jobs.
if [ "$PR_CI_JOB" == "1" ]; then
  echo "PR_CI_JOB set; skipping tidy"
  SKIP_TIDY="--skip tidy"
fi

../x.py --stage 2 test \
  ${SKIP_TIDY:+$SKIP_TIDY} \
  --skip tests \
  --skip coverage-map \
  --skip coverage-run \
  --skip library \
  --skip tidyselftest
---
Executing "/scripts/stage_2_test_set1.sh"
+ /scripts/stage_2_test_set1.sh
PR_CI_JOB set; skipping tidy
+ '[' 1 == 1 ']'
+ echo 'PR_CI_JOB set; skipping tidy'
+ SKIP_TIDY='--skip tidy'
+ ../x.py --stage 2 test --skip tidy --skip compiler --skip src
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2026-01-21/rustfmt-nightly-aarch64-unknown-linux-gnu.tar.xz
---
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is aarch64
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
---
test [ui] tests/ui/asm/aarch64/type-check-2-2.rs ... ok
test [ui] tests/ui/asm/aarch64/type-check-2.rs ... ok
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ok
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/aarch64/sym.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/asm-with-nested-closure.rs ... ok
test [ui] tests/ui/asm/bad-template.rs#aarch64 ... ok
test [ui] tests/ui/asm/cfg.rs#reva ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/windows-tcb-trash-13259.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-naked_functions_rustic_abi.rs ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/size-of-val-raw-too-big.rs ... ignored, only executed when the pointer width is 32bit (Layout computation rejects this layout for different reasons on 64-bit.)
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
test [ui] tests/ui/layout/thaw-validate-invalid-enum.rs ... ok
---
To only update this specific test, also pass `--test-args lint/rfc-2383-lint-reason/expect_multiple_lints.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/lint/rfc-2383-lint-reason/expect_multiple_lints.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/lint/rfc-2383-lint-reason/expect_multiple_lints" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
warning: this lint expectation is unfulfilled
##[warning]  --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_multiple_lints.rs:8:28
   |
---
------------------------------------------

---- [ui] tests/ui/lint/rfc-2383-lint-reason/expect_multiple_lints.rs stdout end ----
---- [ui] tests/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs stdout ----
Saved the actual stderr to `/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383/expect_tool_lint_rfc_2383.stderr`
diff of stderr:

1 warning: this lint expectation is unfulfilled
-   --> $DIR/expect_tool_lint_rfc_2383.rs:37:18
+   --> $DIR/expect_tool_lint_rfc_2383.rs:32:14
---
+   --> $DIR/expect_tool_lint_rfc_2383.rs:37:18
11    |
- LL |     #[expect(dead_code)]
-    |              ^^^^^^^^^
+ LL |         #[expect(invalid_nan_comparisons)]
+    |                  ^^^^^^^^^^^^^^^^^^^^^^^
14 
15 warning: 2 warnings emitted
16 

Note: some mismatched output was normalized before being compared
-   --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs:32:14
-   --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs:37:18
+   --> $DIR/expect_tool_lint_rfc_2383.rs:32:14
+ LL |     #[expect(dead_code)]
+    |              ^^^^^^^^^
+   --> $DIR/expect_tool_lint_rfc_2383.rs:37:18
+ LL |         #[expect(invalid_nan_comparisons)]
+    |                  ^^^^^^^^^^^^^^^^^^^^^^^


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
warning: this lint expectation is unfulfilled
##[warning]  --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs:32:14
   |
---
- 
- warning: this lint expectation is unfulfilled
20   --> $DIR/expect_unfulfilled_expectation.rs:12:10
21    |
22 LL | #[expect(unfulfilled_lint_expectations, reason = "a local: idk why you would expect this")]

24    |
25    = note: a local: idk why you would expect this
26    = note: the `unfulfilled_lint_expectations` lint can't be expected and will always produce this message
+ 
+ warning: this lint expectation is unfulfilled
+   --> $DIR/expect_unfulfilled_expectation.rs:17:14
+    |
+ LL |     #[expect(unused_mut, reason = "this expectation will create a diagnostic with the default lint level")]
+    |              ^^^^^^^^^^
+    |
+    = note: this expectation will create a diagnostic with the default lint level
27 
28 warning: this lint expectation is unfulfilled
---
+ 
+ warning: this lint expectation is unfulfilled
+   --> $DIR/expect_unfulfilled_expectation.rs:17:14
+    |
+ LL |     #[expect(unused_mut, reason = "this expectation will create a diagnostic with the default lint level")]
+    |              ^^^^^^^^^^
+    |
+    = note: this expectation will create a diagnostic with the default lint level


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args lint/rfc-2383-lint-reason/expect_unfulfilled_expectation.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/lint/rfc-2383-lint-reason/expect_unfulfilled_expectation.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/lint/rfc-2383-lint-reason/expect_unfulfilled_expectation" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
warning: this lint expectation is unfulfilled
##[warning]  --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_unfulfilled_expectation.rs:6:11
   |
LL | #![expect(unfulfilled_lint_expectations, reason = "idk why you would expect this")]
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: idk why you would expect this
   = note: the `unfulfilled_lint_expectations` lint can't be expected and will always produce this message
   = note: `#[warn(unfulfilled_lint_expectations)]` on by default

warning: this lint expectation is unfulfilled
##[warning]  --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_unfulfilled_expectation.rs:12:10
   |
LL | #[expect(unfulfilled_lint_expectations, reason = "a local: idk why you would expect this")]
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: a local: idk why you would expect this
   = note: the `unfulfilled_lint_expectations` lint can't be expected and will always produce this message

warning: this lint expectation is unfulfilled
##[warning]  --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_unfulfilled_expectation.rs:17:14
   |
LL |     #[expect(unused_mut, reason = "this expectation will create a diagnostic with the default lint level")]
   |              ^^^^^^^^^^
   |
   = note: this expectation will create a diagnostic with the default lint level

warning: this lint expectation is unfulfilled
##[warning]  --> /checkout/tests/ui/lint/rfc-2383-lint-reason/expect_unfulfilled_expectation.rs:24:22
   |
LL |     #[expect(unused, unfulfilled_lint_expectations, reason = "the expectation for `unused` should be fulfilled")]
   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: the expectation for `unused` should be fulfilled
   = note: the `unfulfilled_lint_expectations` lint can't be expected and will always produce this message

rust-bors · 2026-03-04T16:15:09Z

☀️ Try build successful (CI)
Build commit: 2b27470 (2b27470284d8dbb36abe146c47345ecce04bcc28, parent: b90dc1e597db0bbc0cab0eccb39747b1a9d7e607)

JonathanBrouwer · 2026-03-04T16:19:40Z

@rust-timer queue

JonathanBrouwer · 2026-03-04T16:20:01Z

@rust-timer build 2b27470

rust-timer · 2026-03-04T17:00:10Z

Finished benchmarking commit (2b27470): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.1%, 0.5%]	5
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.1%]	22
Improvements ✅ (secondary)	-0.3%	[-0.7%, -0.0%]	42
All ❌✅ (primary)	-0.3%	[-0.5%, -0.1%]	22

Max RSS (memory usage)

Results (primary 0.9%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.6%, 3.2%]	5
Regressions ❌ (secondary)	3.7%	[0.7%, 6.7%]	12
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-4.6%	[-4.6%, -4.6%]	1
All ❌✅ (primary)	0.9%	[-2.4%, 3.2%]	6

Cycles

Results (primary 2.7%, secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[1.7%, 4.1%]	9
Regressions ❌ (secondary)	3.8%	[1.7%, 6.1%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[1.7%, 4.1%]	9

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.576s -> 480.152s (0.12%)
Artifact size: 397.00 MiB -> 395.12 MiB (-0.47%)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 9, 2026

This comment has been minimized.

Sign in to view

Bryntet force-pushed the lint_attrs branch from 6d9cad0 to 6568db4 Compare February 9, 2026 05:46

This comment has been minimized.

Sign in to view

Bryntet force-pushed the lint_attrs branch from 6568db4 to 1c130a6 Compare February 9, 2026 18:47

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Feb 9, 2026

Tracking issue: Attribute refactor #131229

Open

9 tasks

Bryntet force-pushed the lint_attrs branch from 1c130a6 to 1139fa4 Compare February 9, 2026 19:45

This comment has been minimized.

Sign in to view

Bryntet force-pushed the lint_attrs branch from 1139fa4 to 3431f73 Compare February 14, 2026 17:02

Bryntet force-pushed the lint_attrs branch from 3431f73 to 4a2a189 Compare February 22, 2026 18:55

rustbot added the T-clippy Relevant to the Clippy team. label Feb 22, 2026

rustbot assigned JonathanBrouwer and jdonszelmann Feb 22, 2026

Bryntet changed the title ~~lint attrs~~ Port lint attributes to attribute parser Feb 22, 2026

Bryntet marked this pull request as ready for review February 22, 2026 18:57

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 22, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026

Auto merge of #152369 - Bryntet:lint_attrs, r=<try>

46a7bb3

Port lint attributes to attribute parser

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 22, 2026

Bryntet force-pushed the lint_attrs branch 2 times, most recently from e70b414 to d9434c9 Compare February 22, 2026 20:19

JonathanBrouwer reviewed Feb 22, 2026

View reviewed changes

compiler/rustc_passes/src/check_attr.rs Outdated Show resolved Hide resolved

Bryntet force-pushed the lint_attrs branch from d9434c9 to a0d52ad Compare February 22, 2026 21:05

tidy

1b67abe

Bryntet force-pushed the lint_attrs branch from a3578e1 to 1b67abe Compare March 4, 2026 11:35

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #152369 - Bryntet:lint_attrs, r=<try>

ac4191a

Port lint attributes to attribute parser

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

deduplicate unused expect lints

37c5a91

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #152369 - Bryntet:lint_attrs, r=<try>

2b27470

Port lint attributes to attribute parser

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Mar 4, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

Uh oh!

Conversation

Bryntet commented Feb 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Feb 22, 2026

Uh oh!

JonathanBrouwer commented Feb 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

rustbot commented Mar 4, 2026

Uh oh!

Bryntet commented Mar 4, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 4, 2026

Uh oh!

This comment has been minimized.

Bryntet commented Mar 4, 2026

Uh oh!

blyxyas commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 4, 2026

Uh oh!

Bryntet commented Mar 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 4, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

rust-log-analyzer commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

JonathanBrouwer commented Mar 4, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 4, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Bryntet commented Feb 9, 2026 •

edited by rustbot

Loading